Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move typesdb with concat resources #996

Merged
merged 1 commit into from
May 5, 2022

Conversation

fe80
Copy link
Contributor

@fe80 fe80 commented Apr 5, 2022

Hello,

This is a proposal.

Actually it's not possible to add types without a specific configuration without change $collect::typesdb param. (or I've miss something maybe ?)

With this feature you can have:

cat typesdb.conf 
TypesDB "/usr/share/collectd/types.db"
TypesDB "/etc/collectd/collectd.d/dbi_mysql.typesdb"

with a single declaration

  collectd::typesdb { 'typedb_mysql':
    path    => "${collectd::config_dir}/dbi_mysql.typesdb",
    include => true,
  }

Pull Request (PR) description

This feature is available only if $collectd::purge_config is set at true

  • Add an include of <collectd_dir>/typesdb.conf in the collectd.conf
  • Create a concat resource for <collectd_dir>/typesdb.conf
  • Move $collectd::config::typesdb on the <collectd_dir>/typesdb.conf
    file
  • Add include param to collectd::typesdb, for dynamic addition on typesdb.conf

This Pull Request (PR) fixes the following issues

This feature is available only if $collectd::purge_config is set at true

* Add an include of <collectd_dir>/typesdb.conf in the collectd.conf
* Create a concat resource for <collectd_dir>/typesdb.conf
* Move $collectd::config::typesdb on the <collectd_dir>/typesdb.conf
  file
* Add include param to collectd::typesdb, for dynamic addition on typesdb.conf
@bastelfreak bastelfreak added the enhancement New feature or request label May 5, 2022
@bastelfreak bastelfreak merged commit 15abfa2 into voxpupuli:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants